Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

Why isn't xTxLock in xQueueHandle volatile

Posted by Justin on August 1, 2012
I am reading queue.c from FreeRTOS version 7.1.1

I am noticing that xTxLock is accessed both from ISR and task code (same for xRxLock).

Wouldn't it need to be declared volatile to ensure that neither the task called function does not cache the value in a register?




RE: Why isn't xTxLock in xQueueHandle volatile

Posted by Justin on August 1, 2012
Forgot to add that is is similar to this post http://www.freertos.org/FreeRTOS_Support_Forum_Archive/September_2006/freertos_Queues_and_compiler_optimization_GCC_1582595.html

But there did not appear to be a definitive answer.

RE: Why isn't xTxLock in xQueueHandle volatile

Posted by Dave on August 2, 2012
Interesting question. I think volatile is often used to often in FreeRTOS and could be speeded up with less but I'm not sure in this case.

Looking at xTxLock,

It is used in xQueueGenericSendFromISR() where the function tests and sets a value in a structure passed in as a pointer. The optimizer cannot determine how the value is used so should not optimize the code away.

It is used in prvUnlockQueue() where the same logic applies but in this case the function is quite short so the optimizer could potentially try and inline it.

It is used in the macro prvLockQueue() which is used in xQueueGenericSend() and xQueueGenericReceive() which are also the functions that call prvUnlockQueue(), so if prvUnlockQueue() is inlined the compiler can see xTxLock is being used but might not see why as it is never tested.

Comments Richard?

RE: Why isn't xTxLock in xQueueHandle volatile

Posted by Richard on August 2, 2012
There might be something in this, as the compiler does not know the value is being tested in an interrupt, I'm looking into it.

Regards.

RE: Why isn't xTxLock in xQueueHandle volatile

Posted by Richard on August 2, 2012
Having looked at this, my conclusion is that the xTxLock and xRxLock variables should probably be made volatile, for absolute certainty, although it is probably not necessary.

My reasoning is that the locking and unlocking is not performed in the same function. While the locking is inline, the unlocking is performed by a separate function (prvUnlockQueue()), therefore the compiler will probably not see an increment then decrement of the lock count without the incremented value ever being used unless prvUnlockQueue() was itself inlined - which is unlikely - or cross function optimisation was used.

However, as the word "probably" appears in that sentence, it makes sense to make them volatile. Thanks for pointing this out.

Interestingly the uxMessagesWaiting value is volatile, but probably does not need to be, as it is incremented and decremented in completely different functions, with completely different execution patterns. Dare I take that out though :o)

Regards.


RE: Why isn't xTxLock in xQueueHandle volatile

Posted by Justin on August 3, 2012
Thanks for your analysis.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists