Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by miclam on August 11, 2017

Hello,

I'm currently testing the DNS client of +TCPmulti. When using 8.8.8.8 as DNS server I noticed, that eARPGetCacheEntry does not resolve unmatched remote ip addresses to the default gateway. This is because FreeRTOSFindEndPointOnNetMask returns either the correct EndPoint, or the default EndPoint, and only in case no default is set NULL. eARPGetCacheEntry then checks by if( pxEndPoint == NULL ) (Line 456 in FreeRTOS_ARP.c) if the default gateway should be used, which is never reached.

My idea was to let FreeRTOSFindEndPointOnNetMask return NULL instead of the default EndPoint, and to explicitly call FreeRTOSFindDefaultEndPoint wherever the default EndPoint is required. But FreeRTOS_FindEndPointOnNetMask is used in quiet a lot locations, I'm afraid of breaking something without knowing.

What do you think?

Many thanks, Michael


FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by miclam on August 11, 2017

Hello, as far as I can see commenting out pxEndPoint = pxDefault; in Line 375 in FreeRTOSRouting.c and changing Line 2655 in FreeRTOSIP.c and Line 195 in FreeRTOSUDPIP.c to

        pxNetworkBuffer->pxEndPoint = FreeRTOS_FindEndPointOnNetMask( pxIPPacket->xIPHeader.ulDestinationIPAddress, 7 );
        /* _ML_ Removed default EndPoint from FreeRTOS_FindEndPointOnNetMask, so get it here if needed. */
        if( pxNetworkBuffer->pxEndPoint == NULL )
        {
            pxNetworkBuffer->pxEndPoint = FreeRTOS_FindDefaultEndPoint();
        }

works. The other occurences of FreeRTOS_FindEndPointOnNetMask seem to actually expect it not to return the default gateway.

Regards, Michael


FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by heinbali01 on August 11, 2017

See my reponse here


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists