Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

Minor bug in 4.3.1 xQueueSend()/XQueueRecieve

Posted by Dan on July 27, 2007
In 4.3.1:

Small issue in xQueueSend() and xQueueReceive() in queue.c.

Near the end, where it has the code:

if( xTicksToWait > 0 )
{
if( xTaskCheckForTimeOut( &xTimeOut, &xTicksToWait ) == pdFALSE )
{
xReturn = queueERRONEOUS_UNBLOCK;
}
}


I recommend:

#if ( INCLUDE_vTaskSuspend == 1 )
if(( xTicksToWait > 0 ) && ( xTicksToWait != portMAX_DELAY ))
#else
if( xTicksToWait > 0 )
#endif
{
if( xTaskCheckForTimeOut( &xTimeOut, &xTicksToWait ) == pdFALSE )
{
xReturn = queueERRONEOUS_UNBLOCK;
}
}

xTicksToWait is set portMAX_DELAY for indefinite waits, but without
the above change, it will be decremented. This slightly effects
later code, which processes threads differently depending on if
their wait time is portMAX_DELAY or not.


Dan Searles

RE: Minor bug in 4.3.1 xQueueSend()/XQueueRecieve

Posted by Richard on July 27, 2007
Hmm. I think you have a good point. This part of the code came about from the SafeRTOS validation process - but in SafeRTOS there is no method of waiting indefinitely so the problem does not exist. The error was made when integrating this into the FreeRTOS.org code.

I think the fix would be better in xTaskCheckForTimeOut() to prevent it being duplicated in xQueueSend() and xQueueReceive(). Also these two functions are alread the most complex in the system, so best not to add code to them if possible.

Thank you for your contribution.

Regards.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists