Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

some bug fixes regarding unterminated comment

Posted by Domen Puncer on March 5, 2009
Hello!

Data abort isn't really useful, if it happens because sp was corrupted, and it doesn't have it's own stack. ;-)

This seems to have propagated around:
Demo/ARM7_LPC2106_GCC/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/WizNET_DEMO_GCC_ARM7/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/ARM7_LPC2368_Eclipse/RTOSDemo/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode


Also this one is needed in Demo/ARM7_LPC2368_Eclipse/:
/* definition: char *pcStatus[ 3 ]; so pcStatus[3] (used later) is not valid */
+++ webserver/httpd-cgi.c (working copy)
@@ -235,7 +235,7 @@

static unsigned short generate_io_state( void *arg )
{
- for( ulString = 0; ulString < 4; ulString++ )
+ for( ulString = 0; ulString < 3; ulString++ )
{
if( uxParTextGetLED( ulString + 5 ) )
{

RE: some bug fixes regarding unterminated com

Posted by Richard on March 5, 2009
Which version are you using? I just took a look at this and the comments seem to be terminated?

Regards.

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 6, 2009
5.1.2?

RE: some bug fixes regarding unterminated com

Posted by Richard on March 6, 2009
Maybe I am misunderstanding your comment here. Can you say again what is wrong with the first part of your comment here:

"Data abort isn't really useful, if it happens because sp was corrupted, and it doesn't have it's own stack. ;-)

This seems to have propagated around:
Demo/ARM7_LPC2106_GCC/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/WizNET_DEMO_GCC_ARM7/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/ARM7_LPC2368_Eclipse/RTOSDemo/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode "

I have fixed the loop count problem in SVN - thanks.

Regards.

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 9, 2009
OK, it seems I wasn't clear, lets try it this way:

from Demo/ARM7_LPC2106_GCC/boot.s:
44 _mainCRTStartup:
45
46 /* Setup a stack for each mode - note that this only sets up a usable stack
47 for system/user, SWI and IRQ modes. Also each mode is setup with
48 interrupts initially disabled. */
49 ldr r0, .LC6
50 msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
51 mov sp, r0
52 sub r0, r0, #UND_STACK_SIZE

The comment in line 50 is not terminated.

RE: some bug fixes regarding unterminated com

Posted by Dave on March 9, 2009
Which version are you using? Did you get the source from the zip file or from SVN?

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 10, 2009
5.1.2, zip

RE: some bug fixes regarding unterminated com

Posted by Richard on March 10, 2009
Doh! This is now fixed in three places in the SVN repository. Thanks.

Regards.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists