Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

xSemaphore scope question SAM7_EMAC

Posted by Chris Strahm on November 25, 2008
In the lwIP 1.30 port with SAM7X, there are files:

"SAM7_EMAC.c"
"SAM7_EMAC_ISR.c"

There is the same variable defined local in both files: xSemaphore

/* The semaphore used by the EMAC ISR to wake the EMAC task. */
static xSemaphoreHandle xSemaphore = NULL;

It seems like this variable is suppose to handle the communication between the ISR and regular code. But since the variable is called out local in both, I don't quite see how that could happen. Code from either module is going to access different variables.

Is this actually correct? If so I would recommend naming the two variables different to avoid confusion.

Chris.




RE: xSemaphore scope question SAM7_EMAC

Posted by Dave on November 26, 2008
The semaphore is created in one file, then its value is passed into the other file during the initialization. Although there are two variables, they both hold the same value which is just a pointer to the semaphore structure.

RE: xSemaphore scope question SAM7_EMAC

Posted by Chris Strahm on November 26, 2008
Thanks for the explanation. Seems like an odd way of doing things. In my port I think I will change this to declare the var global in emac.c, then extern in emac_isr.c, and eliminate the copy function. It wastes RAM to save 2 copies of the same var, and it wastes ROM on the copy function.

RE: xSemaphore scope question SAM7_EMAC

Posted by Dave on November 26, 2008
I'm with you there. I think this code results from an anal aversion to using global variables.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists