Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

Change vSemaphoreCreateBinary() to xSemaphoreCreateBinary()

Posted by bhuntting on November 4, 2013

Why does vSemaphoreCreateBinary(xSemaphoreHandle) effectively use pass by reference rather than return a value like xSemaphoreCreateMutex()?

Is there some reason this has not been retired and replaced it with an xSemaphoreCreateBinary() that returns an xSemaphoreHandle like xSemaphoreCreateMutex()? I ask because mocking out vSemaphoreCreateBinary() for testing (with CMock) is very cumbersome compared to mocking out xSemaphoreCreateMutex().


Change vSemaphoreCreateBinary() to xSemaphoreCreateBinary()

Posted by richardbarry on November 4, 2013

It is a purely historical anomaly - and agree it is a nuisance as the calling semantics are different to any other function (it is a macro, not a function, for a start).

It cannot be retired because to do so would break lots of peoples code, including hundreds of demo applications we maintain ourselves...

...however, there is no reason why we don't introduce an xSemaphoreCreateBinary() function then deprecate the vSemaphoreCreateBinary() macro. xSemaphoreCreateBinary() would be a macro to, but mapped to a call to a call to xQueueGenericCreate(), just as vSemaphoreCreateBinary() calls xQueueGenericCreate() now.

If you want to try this please add the following line to semphr.h, underneath the definition of vSemaphoreCreateBinary():


#define xSemaphoreCreateBinary() xQueueGenericCreate( ( unsigned portBASE_TYPE ) 1, semSEMAPHORE_QUEUE_ITEM_LENGTH, queueQUEUE_TYPE_BINARY_SEMAPHORE )

Let me know if that works for you.

A word of warning though - vSemaphoreCreateBinary() creates the semaphore in such a way that the first call to xSemaphoreTake() will pass, whereas the definition above would create the semaphore such that the first call to xSemaphoreTake() would fail, and not pass until something first 'gave' the semaphore.

Regards.


Change vSemaphoreCreateBinary() to xSemaphoreCreateBinary()

Posted by richardbarry on November 7, 2013

xSemaphoreCreateBinary() is now checked into the head revision.

Regards.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists