Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Real time embedded FreeRTOS mailing list 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT Training




Loading

unsafe snprintf

Posted by Purple Pants on October 12, 2011
The printf-stdarg.c file distributed with FreeRTOS comtains a snprintf() implementation that silently drops the 'count' parameter. That is, it is less safe than the normal sprintf() call since most users won't be aware of this 'feature' and might take less care of buffer overflow potential than if they were forced to use sprintf(). It is difficult to overstate how bad this is. At a minimum, I would suggest that the snprintf function is either removed from the source or have a #warning show on compile.

I appreciate that printf-stdarg.c is a third-party file and only used in the demos. Nevertheless, it is included with the FreeRTOS distribution and recommended in the FreeRTOS Reference Manual. I suspect that most users would assume that is it up the quality of other FreeRTOS code, and be completely oblivious as to the potential problem its use could cause.

RE: unsafe snprintf

Posted by Richard on October 12, 2011
I take your point, I will look into whether it is used anywhere, to see if taking it out would break anything. #warning is not an option, as it would just not compile with many compilers.

The file in question is an ultra light implementation, included mainly to avoid code size bloat and very light stack usage.

Regards.

RE: unsafe snprintf

Posted by Purple Pants on October 13, 2011
Thanks. I realise it is meant to be a lite implementation, but 'lite' shouldn't mean maliciously broken! :)

Perhaps removing the '(void)count;' line might be a reasonable halfway house - its only purpose is to prevent the compiler warning that count isn't used, after all.

As to removing it, a search on 'snprintf' and replace of 'sprintf' will do the job - since it actually is sprintf under the bonnet, changing all calls to the real thing won't make anything worse.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) 2004-2010 Richard Barry. Copyright (C) 2010-2016 Real Time Engineers Ltd.
Any and all data, files, source code, html content and documentation included in the FreeRTOSTM distribution or available on this site are the exclusive property of Real Time Engineers Ltd.. See the files license.txt (included in the distribution) and this copyright notice for more information. FreeRTOSTM and FreeRTOS.orgTM are trade marks of Real Time Engineers Ltd.

Latest News:

FreeRTOS V9.0.0 is now available for download.


Free TCP/IP and file system demos for the RTOS


Sponsored Links

⇓ Now With No Code Size Limit! ⇓
⇑ Free Download Without Registering ⇑


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

Renesas Electronics Gold Alliance RTOS Partner.jpg

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

Atmel RTOS partner supporting ARM Cortex-M3 and AVR32 microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Xilinx Microblaze and Zynq partner

Silicon Labs low power RTOS partner

Altera RTOS partner for Nios II and Cortex-A9 SoC

Freescale Alliance RTOS Member supporting ARM and ColdFire microcontrollers

Infineon ARM Cortex-M microcontrollers

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

Cypress RTOS partner supporting ARM Cortex-M3

Fujitsu RTOS partner supporting ARM Cortex-M3 and FM3

Microsemi (previously Actel) RTOS partner supporting ARM Cortex-M3

Atollic Partner

IAR Partner

Keil ARM Partner

Embedded Artists