Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT




Loading

Style question regarding xSemaphoreTake

Posted by JC on August 20, 2008
If one uses xSemaphoreTake with portMAX_DELAY, is it worth checking the return result, assuming we know the semaphore handle to be valid? The question, of course, is what the appropriate course of action is should it fail. With a valid handle and portMAX_DELAY, is it realistically possible for the take to fail?

RE: Style question regarding xSemaphoreTake

Posted by Dave on August 20, 2008
Now that depends :)

If you have INCLUDE_vTaskSuspend defined as 1 then the function will only return it has taken the semaphore and you need not check the return value.

If you have INCLUDE_vTaskSuspend defined as 0 then the call cannot block for ever and will return when portMAX_DELAY ticks has expire and you must check the return value although if you have ticks defined to be a 32bit type this can be days/months/years depending on the tick frequency.

In the latter case the stype is

//Wait on semaphore.
while( xSemaphoreTake( semaphore, portMAX_DELAY ) != 1 );

//We now have the semaphore.

RE: Style question regarding xSemaphoreTake

Posted by JC on August 20, 2008
Glad you mentioned the INCLUDE_vTaskSuspend. I am using that, and had noticed that in the docs, but failed to mention it in my scenario. There didn't seem to be a failure case (other than passing an invalid semaphore), so I thought a call with no error checking should be stylistically OK (unless a stray alpha particle flips a bit in your semaphore handle...)


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) Amazon Web Services, Inc. or its affiliates. All rights reserved.

Latest News

FreeRTOS kernel V10 is available for immediate download. Now MIT licensed.


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

IAR Partner

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

OpenRTOS and SafeRTOS