Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT




Loading

FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by miclam on August 11, 2017

Hello,

I'm currently testing the DNS client of +TCPmulti. When using 8.8.8.8 as DNS server I noticed, that eARPGetCacheEntry does not resolve unmatched remote ip addresses to the default gateway. This is because FreeRTOSFindEndPointOnNetMask returns either the correct EndPoint, or the default EndPoint, and only in case no default is set NULL. eARPGetCacheEntry then checks by if( pxEndPoint == NULL ) (Line 456 in FreeRTOS_ARP.c) if the default gateway should be used, which is never reached.

My idea was to let FreeRTOSFindEndPointOnNetMask return NULL instead of the default EndPoint, and to explicitly call FreeRTOSFindDefaultEndPoint wherever the default EndPoint is required. But FreeRTOS_FindEndPointOnNetMask is used in quiet a lot locations, I'm afraid of breaking something without knowing.

What do you think?

Many thanks, Michael


FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by miclam on August 11, 2017

Hello, as far as I can see commenting out pxEndPoint = pxDefault; in Line 375 in FreeRTOSRouting.c and changing Line 2655 in FreeRTOSIP.c and Line 195 in FreeRTOSUDPIP.c to

        pxNetworkBuffer->pxEndPoint = FreeRTOS_FindEndPointOnNetMask( pxIPPacket->xIPHeader.ulDestinationIPAddress, 7 );
        /* _ML_ Removed default EndPoint from FreeRTOS_FindEndPointOnNetMask, so get it here if needed. */
        if( pxNetworkBuffer->pxEndPoint == NULL )
        {
            pxNetworkBuffer->pxEndPoint = FreeRTOS_FindDefaultEndPoint();
        }

works. The other occurences of FreeRTOS_FindEndPointOnNetMask seem to actually expect it not to return the default gateway.

Regards, Michael


FreeRTOS+TCP_Multi Bug: ARP resolves remote addresses locally

Posted by heinbali01 on August 11, 2017

See my reponse here


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) Amazon Web Services, Inc. or its affiliates. All rights reserved.

Latest News

FreeRTOS kernel V10 is available for immediate download. Now MIT licensed.


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

IAR Partner

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

OpenRTOS and SafeRTOS