Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT




Loading

some bug fixes regarding unterminated comment

Posted by Domen Puncer on March 5, 2009
Hello!

Data abort isn't really useful, if it happens because sp was corrupted, and it doesn't have it's own stack. ;-)

This seems to have propagated around:
Demo/ARM7_LPC2106_GCC/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/WizNET_DEMO_GCC_ARM7/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/ARM7_LPC2368_Eclipse/RTOSDemo/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode


Also this one is needed in Demo/ARM7_LPC2368_Eclipse/:
/* definition: char *pcStatus[ 3 ]; so pcStatus[3] (used later) is not valid */
+++ webserver/httpd-cgi.c (working copy)
@@ -235,7 +235,7 @@

static unsigned short generate_io_state( void *arg )
{
- for( ulString = 0; ulString < 4; ulString++ )
+ for( ulString = 0; ulString < 3; ulString++ )
{
if( uxParTextGetLED( ulString + 5 ) )
{

RE: some bug fixes regarding unterminated com

Posted by Richard on March 5, 2009
Which version are you using? I just took a look at this and the comments seem to be terminated?

Regards.

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 6, 2009
5.1.2?

RE: some bug fixes regarding unterminated com

Posted by Richard on March 6, 2009
Maybe I am misunderstanding your comment here. Can you say again what is wrong with the first part of your comment here:

"Data abort isn't really useful, if it happens because sp was corrupted, and it doesn't have it's own stack. ;-)

This seems to have propagated around:
Demo/ARM7_LPC2106_GCC/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/WizNET_DEMO_GCC_ARM7/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
Demo/ARM7_LPC2368_Eclipse/RTOSDemo/boot.s: msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode "

I have fixed the loop count problem in SVN - thanks.

Regards.

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 9, 2009
OK, it seems I wasn't clear, lets try it this way:

from Demo/ARM7_LPC2106_GCC/boot.s:
44 _mainCRTStartup:
45
46 /* Setup a stack for each mode - note that this only sets up a usable stack
47 for system/user, SWI and IRQ modes. Also each mode is setup with
48 interrupts initially disabled. */
49 ldr r0, .LC6
50 msr CPSR_c, #MODE_UND|I_BIT|F_BIT /* Undefined Instruction Mode
51 mov sp, r0
52 sub r0, r0, #UND_STACK_SIZE

The comment in line 50 is not terminated.

RE: some bug fixes regarding unterminated com

Posted by Dave on March 9, 2009
Which version are you using? Did you get the source from the zip file or from SVN?

RE: some bug fixes regarding unterminated com

Posted by Domen Puncer on March 10, 2009
5.1.2, zip

RE: some bug fixes regarding unterminated com

Posted by Richard on March 10, 2009
Doh! This is now fixed in three places in the SVN repository. Thanks.

Regards.


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) Amazon Web Services, Inc. or its affiliates. All rights reserved.

Latest News

FreeRTOS kernel V10 is available for immediate download. Now MIT licensed.


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

IAR Partner

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

OpenRTOS and SafeRTOS