Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem


Klockwork issue in timers.c

Posted by Richard on November 2, 2012
Hi all,

We run Klockwork on our code base - a static code analysis tool. It complains about a possible NULL pointer deference in the function prvProcessReceivedCommands in timers.c.

In trying to follow the code through to see if this is at all possible, I came across a comment on line 508 that talks about a timer command, trmCOMMAND_PROCESS_TIMER_OVERFLOW which does not appear to exist in the code. This implies that the logic following on 511 will always run since there does not appear to be any time when the pxTimer is set to NULL.

Is this just code and/or comments left over from prior releases of FreeRTOS or am I missing something?

Many thanks
Richard Jackson

RE: Klockwork issue in timers.c

Posted by Richard on November 2, 2012
I've just had a look at this and don't think you are missing something. The code looks obsolete (although benign) and has been removed.

Thanks and regards.

[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]

Copyright (C) Amazon Web Services, Inc. or its affiliates. All rights reserved.

Latest News

Meet us at Embedded World. Hall 3A-525.

Hear from Richard Barry at Embedded World. Feb 28, 16:00, Hall 4-428.

Video: Watch James Gosling & Richard Barry at re:Invent, Las Vegas 2017.

FreeRTOS kernel V10.0.1 is available for immediate download. Now MIT licensed.

FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

IAR Partner

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

OpenRTOS and SafeRTOS