Quality RTOS & Embedded Software

 Real time embedded FreeRTOS RSS feed 
Quick Start Supported MCUs PDF Books Trace Tools Ecosystem TCP & FAT




Loading

Bad assert in queue.c xQueueGenericCreate

Posted by hairymnstr on September 10, 2015

In queue.c from FreeRTOS 8.2.2 the xQueueGenericCreate function ends (see line 383 on) with:

configASSERT( xReturn );

return xReturn;

so it's impossible for the function to return NULL without triggering the assertion. However the documentation (http://www.freertos.org/a00116.html) states that xQueueCreate can return 0 to indicate failure.

If assertions were turned off this function would operate as documented, so it seems like this assert should not be present.


Bad assert in queue.c xQueueGenericCreate

Posted by rtel on September 10, 2015

Its gone! [but the change is not checked in yet]

If you have a malloc failed hook defined then that will get called anyway, so it was perhaps a little obsolete.


Bad assert in queue.c xQueueGenericCreate

Posted by hairymnstr on March 23, 2016

Looks like this change never got checked in, I'm still seeing this assert in 8.2.3 and 9.0.0rc1


Bad assert in queue.c xQueueGenericCreate

Posted by rtel on March 23, 2016

Look at the definitions of xQueueGenericCreate() and xQueueGenericCreateStatic() in the head revision (lines 384 and 332 at the time of posting) - the assert was removed, but after rc1. Since rc1 some simplification of the static allocation code has been made.

https://sourceforge.net/p/freertos/code/HEAD/tree/trunk/FreeRTOS/Source/queue.c


Bad assert in queue.c xQueueGenericCreate

Posted by hairymnstr on March 23, 2016

Excellent, thanks. Another reason to look forward to 9.0.0!


[ Back to the top ]    [ About FreeRTOS ]    [ Sitemap ]    [ ]




Copyright (C) Amazon Web Services, Inc. or its affiliates. All rights reserved.

Latest News

FreeRTOS kernel V10 is available for immediate download. Now MIT licensed.


FreeRTOS Partners

ARM Connected RTOS partner for all ARM microcontroller cores

IAR Partner

Microchip Premier RTOS Partner

RTOS partner of NXP for all NXP ARM microcontrollers

STMicro RTOS partner supporting ARM7, ARM Cortex-M3, ARM Cortex-M4 and ARM Cortex-M0

Texas Instruments MCU Developer Network RTOS partner for ARM and MSP430 microcontrollers

OpenRTOS and SafeRTOS